Don't consider neutral reviews to be positive

This commit is contained in:
rubenwardy
2023-04-15 20:06:24 +01:00
parent c9e8df7f5b
commit a97da15359
3 changed files with 4 additions and 4 deletions

View File

@@ -429,9 +429,9 @@ def list_all_reviews():
if request.args.get("is_positive"):
if isYes(request.args.get("is_positive")):
query = query.filter(PackageReview.rating >= 3)
query = query.filter(PackageReview.rating > 3)
else:
query = query.filter(PackageReview.rating < 3)
query = query.filter(PackageReview.rating <= 3)
q = request.args.get("q")
if q:

View File

@@ -47,7 +47,7 @@ def home():
.limit(20)).all()
updated = updated[:4]
reviews = review_load(PackageReview.query.filter(PackageReview.rating >= 3)
reviews = review_load(PackageReview.query.filter(PackageReview.rating > 3)
.order_by(db.desc(PackageReview.created_at))).limit(5).all()
downloads_result = db.session.query(func.sum(Package.downloads)).one_or_none()

View File

@@ -194,7 +194,7 @@ class PackageReview(db.Model):
def getAsDictionary(self, include_package=False):
pos, neg, _user = self.get_totals()
ret = {
"is_positive": self.rating >= 3,
"is_positive": self.rating > 3,
"rating": self.rating,
"user": {
"username": self.author.username,