Windlight floaters' isOpen() functions were always returning true after singleton was created, regardless of current visiblity status. Resulted in pointless syncMenu calls which are very expensive.

indra/newview/llfloaterdaycycle.cpp

@@ -288,7 +288,7 @@ bool LLFloaterDayCycle::isOpen()
 {
 	if (sDayCycle != NULL) 
 	{
-		return true;
+		return sDayCycle->getVisible();
 	}
 	return false;
 }

indra/newview/llfloaterenvsettings.cpp

@@ -197,7 +197,7 @@ bool LLFloaterEnvSettings::isOpen()
 {
 	if (sEnvSettings != NULL) 
 	{
-		return true;
+		return sEnvSettings->getVisible();
 	}
 	return false;
 }

indra/newview/llfloaterwater.cpp

@@ -316,7 +316,7 @@ void LLFloaterWater::show()
 bool LLFloaterWater::isOpen()
 {
 	if (sWaterMenu != NULL) {
-		return true;
+		return sWaterMenu->getVisible();
 	}
 	return false;
 }

indra/newview/llfloaterwindlight.cpp

@@ -473,7 +473,7 @@ void LLFloaterWindLight::show()
 bool LLFloaterWindLight::isOpen()
 {
 	if (sWindLight != NULL) {
-		return true;
+		return sWindLight->getVisible();
 	}
 	return false;
 }