Singularity-Viewer/SingularityViewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[NameUI] Remove pointless is_group check in refresh

Browse Source
This commit is contained in:
Liru Færs
2020-01-06 07:40:48 -05:00
parent a870534ea0
commit af2ae76ca2
3 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
indra/newview/llnameui.cpp
View File

@@ -123,7 +123,7 @@ void LLNameUI::setNameText()
setText(got_name ? name : mInitialValue);
}
void LLNameUI::refresh(const LLUUID& id, const std::string& full_name, bool is_group)
void LLNameUI::refresh(const LLUUID& id, const std::string& full_name)
{
if (id == mNameID)
{
@@ -131,12 +131,11 @@ void LLNameUI::refresh(const LLUUID& id, const std::string& full_name, bool is_g
}
}
void LLNameUI::refreshAll(const LLUUID& id, const std::string& full_name, bool is_group)
void LLNameUI::refreshAll(const LLUUID& id, const std::string& full_name)
{
if (!is_group) return;
for (auto box : sInstances)
{
box->refresh(id, full_name, is_group);
box->refresh(id, full_name);
}
}

4
indra/newview/llnameui.h
View File

@@ -54,8 +54,8 @@ struct LLNameUI : public LFIDBearer
void setIsGroup(bool is_group);
void setNameID(const LLUUID& name_id, bool is_group);
void setNameText(); // Sets the name to whatever the name cache has at the moment
void refresh(const LLUUID& id, const std::string& full_name, bool is_group);
static void refreshAll(const LLUUID& id, const std::string& full_name, bool is_group);
void refresh(const LLUUID& id, const std::string& name);
static void refreshAll(const LLUUID& id, const std::string& name);
void showProfile();

2
indra/newview/llstartup.cpp
View File

@@ -319,7 +319,7 @@ void transition_back_to_login_panel(const std::string& emsg);
void callback_cache_name(const LLUUID& id, const std::string& full_name, bool is_group)
{
LLNameUI::refreshAll(id, full_name, is_group);
LLNameUI::refreshAll(id, full_name);
// TODO: Actually be intelligent about the refresh.
// For now, just brute force refresh the dialogs.