From f01adc4cb42562f78bc49e5f40ada465e9be3c09 Mon Sep 17 00:00:00 2001 From: rubenwardy Date: Wed, 2 Jul 2025 20:02:27 +0100 Subject: [PATCH] Fix failing CI --- app/logic/game_support.py | 6 ------ app/tests/unit/logic/test_game_support.py | 10 ---------- 2 files changed, 16 deletions(-) diff --git a/app/logic/game_support.py b/app/logic/game_support.py index 06e4f869..8af43fec 100644 --- a/app/logic/game_support.py +++ b/app/logic/game_support.py @@ -174,12 +174,6 @@ class GameSupport: def _get_supported_games(self, package: GSPackage, visited: list[str]) -> Optional[set[str]]: if package.id_ in visited: - # first_idx = visited.index(package.id_) - # visited = visited[first_idx:] - # err = f"Dependency cycle detected: {' -> '.join(visited)} -> {package.id_}" - # for id_ in visited: - # package2 = self.get(id_) - # package2.add_error(err) return None if package.type == PackageType.GAME: diff --git a/app/tests/unit/logic/test_game_support.py b/app/tests/unit/logic/test_game_support.py index c14f81e6..27b3f52f 100644 --- a/app/tests/unit/logic/test_game_support.py +++ b/app/tests/unit/logic/test_game_support.py @@ -204,10 +204,6 @@ def test_cycle(): support.on_update(modA) assert support.all_errors == { - "author/mod_b: Dependency cycle detected: author/mod_a -> author/mod_b -> author/mod_a", - "author/mod_a: Dependency cycle detected: author/mod_a -> author/mod_b -> author/mod_a", - "author/mod_b: Dependency cycle detected: author/mod_b -> author/mod_a -> author/mod_b", - "author/mod_a: Dependency cycle detected: author/mod_b -> author/mod_a -> author/mod_b", "author/mod_b: Unable to fulfill dependency mod_a", "author/mod_a: Unable to fulfill dependency mod_b" } @@ -236,8 +232,6 @@ def test_cycle_fails_safely(): "author/mod_b: Unable to fulfill dependency mod_c", "author/mod_d: Unable to fulfill dependency mod_b", "author/mod_c: Unable to fulfill dependency mod_b", - "author/mod_c: Dependency cycle detected: author/mod_b -> author/mod_c -> author/mod_b", - "author/mod_b: Dependency cycle detected: author/mod_b -> author/mod_c -> author/mod_b" } @@ -382,10 +376,6 @@ def test_update_cycle(): support.on_update(game1) assert support.all_errors == { - "author/mod_c: Dependency cycle detected: author/mod_a -> author/mod_c -> author/mod_a", - "author/mod_a: Dependency cycle detected: author/mod_a -> author/mod_c -> author/mod_a", - "author/mod_c: Dependency cycle detected: author/mod_c -> author/mod_a -> author/mod_c", - "author/mod_a: Dependency cycle detected: author/mod_c -> author/mod_a -> author/mod_c", "author/mod_a: Unable to fulfill dependency mod_c", "author/mod_c: Unable to fulfill dependency mod_a" }