diff --git a/app/flatpages/help/ranks_permissions.md b/app/flatpages/help/ranks_permissions.md index 93a337c9..5a2d5928 100644 --- a/app/flatpages/help/ranks_permissions.md +++ b/app/flatpages/help/ranks_permissions.md @@ -69,6 +69,21 @@ title: Ranks and Permissions ✓ ✓ + + Delete Package + + + + + + + ✓ + ✓ + ✓ + ✓ + ✓ + ✓ + Edit Package diff --git a/app/models.py b/app/models.py index cda52380..2b12562f 100644 --- a/app/models.py +++ b/app/models.py @@ -708,9 +708,10 @@ class Package(db.Model): elif perm == Permission.EDIT_MAINTAINERS: return isOwner or user.rank.atLeast(UserRank.MODERATOR) - # Moderators can delete packages - elif perm == Permission.DELETE_PACKAGE or perm == Permission.UNAPPROVE_PACKAGE \ - or perm == Permission.CHANGE_RELEASE_URL: + elif perm == Permission.UNAPPROVE_PACKAGE or perm == Permission.DELETE_PACKAGE: + return user.rank.atLeast(UserRank.EDITOR) + + elif perm == Permission.CHANGE_RELEASE_URL: return user.rank.atLeast(UserRank.MODERATOR) else: