From e86d9a8e88e0dfae4ff44642fb3a14abf5432b74 Mon Sep 17 00:00:00 2001
From: rubenwardy <rw@rubenwardy.com>
Date: Mon, 26 Feb 2024 00:39:59 +0000
Subject: [PATCH] Add empty PackageTranslation for all supported languages in a
 package

---
 app/tasks/importtasks.py        | 32 +++++++++++++++++++-------------
 app/tasks/minetestcheck/tree.py |  8 ++++++++
 2 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/app/tasks/importtasks.py b/app/tasks/importtasks.py
index 2b4608e5..f1964f3a 100644
--- a/app/tasks/importtasks.py
+++ b/app/tasks/importtasks.py
@@ -166,8 +166,23 @@ def post_release_check_update(self, release: PackageRelease, path):
 		# Read translations
 		allowed_languages = set([x[0] for x in db.session.query(Language.id).all()])
 		allowed_languages.discard("en")
-		raw_translations = tree.get_translations(tree.get("textdomain", tree.name))
 		conn = db.session.connection()
+
+		for language in tree.get_supported_languages():
+			if language not in allowed_languages:
+				continue
+
+			values = {
+				"package_id": package.id,
+				"language_id": language,
+			}
+			stmt = insert(PackageTranslation).values(**values)
+			stmt = stmt.on_conflict_do_nothing(
+				index_elements=[PackageTranslation.package_id, PackageTranslation.language_id],
+			)
+			conn.execute(stmt)
+
+		raw_translations = tree.get_translations(tree.get("textdomain", tree.name))
 		for raw_translation in raw_translations:
 			if raw_translation.language not in allowed_languages:
 				continue
@@ -176,19 +191,10 @@ def post_release_check_update(self, release: PackageRelease, path):
 				"title": raw_translation.entries.get(tree.get("title", package.title)),
 				"short_desc": raw_translation.entries.get(tree.get("description", package.short_desc)),
 			}
-			values = {
-				"package_id": package.id,
-				"language_id": raw_translation.language,
-				"title": to_update["title"],
-				"short_desc": to_update["short_desc"],
-			}
 
-			stmt = insert(PackageTranslation).values(**values)
-			stmt = stmt.on_conflict_do_update(
-				index_elements=[PackageTranslation.package_id, PackageTranslation.language_id],
-				set_=to_update
-			)
-			conn.execute(stmt)
+			PackageTranslation.query \
+				.filter_by(package_id=package.id, language_id=raw_translation.language) \
+				.update(to_update)
 
 		# Update min/max
 		if tree.meta.get("min_minetest_version"):
diff --git a/app/tasks/minetestcheck/tree.py b/app/tasks/minetestcheck/tree.py
index a14b7719..56a746d0 100644
--- a/app/tasks/minetestcheck/tree.py
+++ b/app/tasks/minetestcheck/tree.py
@@ -301,6 +301,14 @@ class PackageTreeNode:
 		for child in self.children:
 			child.validate()
 
+	def get_supported_languages(self) -> set[str]:
+		ret = set()
+		for name in glob.glob(f"{self.baseDir}/**/locale/*.*.tr", recursive=True):
+			parts = os.path.basename(name).split(".")
+			ret.add(parts[-2])
+
+		return ret
+
 	def get_translations(self, textdomain: str) -> list[Translation]:
 		ret = []