Fix issues based on linter

This commit is contained in:
rubenwardy
2023-06-18 22:21:37 +01:00
parent f2cfb6c17d
commit d808a5c822
19 changed files with 46 additions and 71 deletions

View File

@@ -134,7 +134,7 @@ def get_package_overview_for_user(user: Optional[User], start_date: datetime.dat
return result
def get_all_package_stats(start_date: Optional[datetime.date], end_date: Optional[datetime.date]):
def get_all_package_stats(start_date: Optional[datetime.date] = None, end_date: Optional[datetime.date] = None):
now_date = datetime.datetime.utcnow().date()
if end_date is None or end_date > now_date:
end_date = now_date

View File

@@ -16,8 +16,10 @@
import json
import re
import typing
import validators
from flask_babel import lazy_gettext
from flask_babel import lazy_gettext, LazyString
from app.logic.LogicError import LogicError
from app.models import User, Package, PackageType, MetaPackage, Tag, ContentWarning, db, Permission, AuditSeverity, \
@@ -26,7 +28,7 @@ from app.utils import addAuditLog, has_blocked_domains, diff_dictionaries, descr
from app.utils.url import clean_youtube_url
def check(cond: bool, msg: str):
def check(cond: bool, msg: typing.Union[str, LazyString]):
if not cond:
raise LogicError(400, msg)

View File

@@ -64,9 +64,9 @@ def do_order_screenshots(_user: User, package: Package, order: [any]):
try:
lookup[int(ss_id)].order = counter
counter += 1
except KeyError as e:
except KeyError:
raise LogicError(400, "Unable to find screenshot with id={}".format(ss_id))
except (ValueError, TypeError) as e:
except (ValueError, TypeError):
raise LogicError(400, "Invalid id, not a number: {}".format(json.dumps(ss_id)))
db.session.commit()
@@ -75,7 +75,7 @@ def do_order_screenshots(_user: User, package: Package, order: [any]):
def do_set_cover_image(_user: User, package: Package, cover_image):
try:
cover_image = int(cover_image)
except (ValueError, TypeError) as e:
except (ValueError, TypeError):
raise LogicError(400, "Invalid id, not a number: {}".format(json.dumps(cover_image)))
for screenshot in package.screenshots.all():