From 7088ffd321e82d7b451ff4db1484fbe112b2a821 Mon Sep 17 00:00:00 2001
From: rubenwardy <rw@rubenwardy.com>
Date: Thu, 10 Dec 2020 11:25:52 +0000
Subject: [PATCH] Add ability for admin to hard delete packages

---
 app/blueprints/admin/admin.py | 12 ++++++++++++
 app/models.py                 | 19 ++++++++++++++-----
 app/templates/admin/list.html | 11 +++++++++++
 3 files changed, 37 insertions(+), 5 deletions(-)

diff --git a/app/blueprints/admin/admin.py b/app/blueprints/admin/admin.py
index 302559b9..969244da 100644
--- a/app/blueprints/admin/admin.py
+++ b/app/blueprints/admin/admin.py
@@ -163,6 +163,18 @@ def admin_page():
 
 			flash("Deleted " + str(count) + " unused meta packages", "success")
 			return redirect(url_for("admin.admin_page"))
+
+		elif action == "delremovedpackages":
+			query = Package.query.filter_by(state=PackageState.DELETED)
+			count = query.count()
+			for pkg in query.all():
+				pkg.review_thread = None
+				db.session.delete(pkg)
+			db.session.commit()
+
+			flash("Deleted {} soft deleted packages packages".format(count), "success")
+			return redirect(url_for("admin.admin_page"))
+
 		else:
 			flash("Unknown action: " + action, "danger")
 
diff --git a/app/models.py b/app/models.py
index bc5c9900..92dafa8c 100644
--- a/app/models.py
+++ b/app/models.py
@@ -167,7 +167,7 @@ class User(db.Model, UserMixin):
 
 	# Content
 	notifications = db.relationship("Notification", foreign_keys="Notification.user_id",
-			order_by=desc(text("Notification.created_at")), back_populates="user",  cascade="all, delete, delete-orphan")
+			order_by=desc(text("Notification.created_at")), back_populates="user", cascade="all, delete, delete-orphan")
 	caused_notifications = db.relationship("Notification", foreign_keys="Notification.causer_id",
 			back_populates="causer", cascade="all, delete, delete-orphan", lazy="dynamic")
 	notification_preferences = db.relationship("UserNotificationPreferences", uselist=False, back_populates="user",
@@ -734,15 +734,24 @@ class Package(db.Model):
 			back_populates="packages")
 
 	releases = db.relationship("PackageRelease", back_populates="package",
-			lazy="dynamic", order_by=db.desc("package_release_releaseDate"))
+			lazy="dynamic", order_by=db.desc("package_release_releaseDate"), cascade="all, delete, delete-orphan")
 
 	screenshots = db.relationship("PackageScreenshot", back_populates="package",
-			lazy="dynamic", order_by=db.asc("package_screenshot_order"))
+			lazy="dynamic", order_by=db.asc("package_screenshot_order"), cascade="all, delete, delete-orphan")
 
 	maintainers = db.relationship("User", secondary=maintainers, lazy="subquery")
 
-	threads = db.relationship("Thread", back_populates="package", order_by=db.desc("thread_created_at"), foreign_keys="Thread.package_id")
-	reviews = db.relationship("PackageReview", back_populates="package", order_by=db.desc("package_review_created_at"))
+	threads = db.relationship("Thread", back_populates="package", order_by=db.desc("thread_created_at"),
+			foreign_keys="Thread.package_id", cascade="all, delete, delete-orphan")
+
+	reviews = db.relationship("PackageReview", back_populates="package", order_by=db.desc("package_review_created_at"),
+			cascade="all, delete, delete-orphan")
+
+	audit_log_entries = db.relationship("AuditLogEntry", foreign_keys="AuditLogEntry.package_id", back_populates="package",
+			order_by=db.desc("audit_log_entry_created_at"), lazy="dynamic")
+
+	tokens = db.relationship("APIToken", foreign_keys="APIToken.package_id", back_populates="package",
+			lazy="dynamic", cascade="all, delete, delete-orphan")
 
 	def __init__(self, package=None):
 		if package is None:
diff --git a/app/templates/admin/list.html b/app/templates/admin/list.html
index 65f36cfa..1a7572fa 100644
--- a/app/templates/admin/list.html
+++ b/app/templates/admin/list.html
@@ -59,6 +59,17 @@
 						<input type="submit" value="Restore" class="col-sm-auto btn btn-primary ml-2" />
 					</div>
 				</form>
+
+				<form method="post" action="" class="card-body">
+					<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
+					<input type="hidden" name="action" value="delremovedpackages" />
+
+					<p>
+						{{ _("Deletion is permanent.") }}
+					</p>
+
+					<input type="submit" value="Delete Removed Packages" class="btn btn-danger" />
+				</form>
 			</div>
 		</div>
 	</div>