From 357348c24e7f2f3284b68f1e0840a0eb9d079b4b Mon Sep 17 00:00:00 2001
From: rubenwardy <rw@rubenwardy.com>
Date: Thu, 22 Feb 2024 12:43:46 +0000
Subject: [PATCH] Add audit log when mods are added to packages

---
 app/tasks/importtasks.py            | 25 ++++++++++++++++++++++++-
 app/templates/packages/similar.html |  6 +++---
 2 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/app/tasks/importtasks.py b/app/tasks/importtasks.py
index ca81115e..5f917227 100644
--- a/app/tasks/importtasks.py
+++ b/app/tasks/importtasks.py
@@ -33,9 +33,10 @@ from app.models import AuditSeverity, db, NotificationType, PackageRelease, Meta
 	PackageGameSupport
 from app.tasks import celery, TaskError
 from app.utils import random_string, post_bot_message, add_system_notification, add_system_audit_log, \
-	get_games_from_list
+	get_games_from_list, add_audit_log
 from app.utils.git import clone_repo, get_latest_tag, get_latest_commit, get_temp_dir
 from .minetestcheck import build_tree, MinetestCheckError, ContentType
+from .webhooktasks import post_discord_webhook
 from app import app
 from app.logic.LogicError import LogicError
 from app.logic.game_support import GameSupportResolver
@@ -108,7 +109,29 @@ def post_release_check_update(self, release: PackageRelease, path):
 		provides = tree.get_mod_names()
 
 		package = release.package
+		old_modnames = set([x.name for x in package.provides])
 		package.provides.clear()
+
+		# If new mods were added, add to audit log
+		if package.state == PackageState.APPROVED:
+			new_provides = []
+			for modname in provides:
+				if modname not in old_modnames:
+					new_provides.append(modname)
+
+			if len(new_provides) > 0:
+				msg = "Added mods: " + (", ".join(new_provides))
+				add_audit_log(AuditSeverity.NORMAL, package.author, msg + " (Post release hook)", release.get_edit_url(), package)
+
+				# Do any of these new mods exist elsewhere?
+				new_names = get_meta_packages(new_provides)
+				if any(map(lambda x: x.packages.filter(Package.state == PackageState.APPROVED).count() > 0, new_names)):
+					discord_msg = (msg + " " + package.get_url("packages.similar", absolute=True) +
+						"#" + new_provides[0] +
+						"\nSome of these mods exist elsewhere, possible RTaN issue")
+					post_discord_webhook.delay(package.author.display_name, discord_msg, True,
+						package.title, package.short_desc, package.get_thumb_url(2, True, "png"))
+
 		package.provides.extend(get_meta_packages(tree.get_mod_names()))
 
 		# Delete all mod name dependencies
diff --git a/app/templates/packages/similar.html b/app/templates/packages/similar.html
index 98d06095..00811dfe 100644
--- a/app/templates/packages/similar.html
+++ b/app/templates/packages/similar.html
@@ -9,12 +9,12 @@
 	<h2>{{ self.title() }}</h2>
 
 	{% if packages_modnames %}
-		<h3>{{ _("Packages sharing provided mods") }}</h3>
+		<h3 id="packages-sharing-provided-mods">{{ _("Packages sharing provided mods") }}</h3>
 		<p class="text-muted">
 			{{ _("This package contains modnames that are present in the following packages:") }}
 		</p>
 		{% for modname, packages in packages_modnames.items() %}
-			<h4>{{ modname.name }}</h4>
+			<h4 id="{{ modname.name }}">{{ modname.name }}</h4>
 			<ul>
 				{% for pkg in packages %}
 					<li>
@@ -29,7 +29,7 @@
 	{% endif %}
 
 	{% if similar_topics %}
-		<h3>{{ _("Similar Forum Topics") }}</h3>
+		<h3 id="similar-forum-topics">{{ _("Similar Forum Topics") }}</h3>
 		<ul>
 			{% for t in similar_topics %}
 				<li>