From 294037ec700fe4714e8afd36ecb6483bae478c92 Mon Sep 17 00:00:00 2001
From: rubenwardy <rw@rubenwardy.com>
Date: Tue, 25 Oct 2022 01:57:38 +0100
Subject: [PATCH] Use level 4 thumbnail for cover image

---
 app/models/packages.py               | 20 +++++++++-----------
 app/templates/index.html             |  2 +-
 app/templates/packages/game_hub.html |  4 ++--
 app/templates/packages/view.html     |  6 +++---
 4 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/app/models/packages.py b/app/models/packages.py
index faf037c8..a1391897 100644
--- a/app/models/packages.py
+++ b/app/models/packages.py
@@ -603,20 +603,18 @@ class Package(db.Model):
 	def getThumbnailOrPlaceholder(self, level=2):
 		return self.getThumbnailURL(level) or "/static/placeholder.png"
 
-	def getThumbnailURL(self, level=2):
+	def getThumbnailURL(self, level=2, abs=False):
 		screenshot = self.main_screenshot
-		return screenshot.getThumbnailURL(level) if screenshot is not None else None
-
-	def getMainScreenshotURL(self, absolute=False):
-		screenshot = self.main_screenshot
-		if screenshot is None:
-			return None
-
-		if absolute:
+		url = screenshot.getThumbnailURL(level) if screenshot is not None else None
+		if abs:
 			from app.utils import abs_url
-			return abs_url(screenshot.url)
+			return abs_url(url)
 		else:
-			return screenshot.url
+			return url
+
+	def getCoverImageURL(self):
+		screenshot = self.cover_image or self.main_screenshot
+		return screenshot and screenshot.getThumbnailURL(4)
 
 	def getURL(self, endpoint, absolute=False, **kwargs):
 		if absolute:
diff --git a/app/templates/index.html b/app/templates/index.html
index d2004a2c..29549f41 100644
--- a/app/templates/index.html
+++ b/app/templates/index.html
@@ -29,7 +29,7 @@
 		</ol>
 		<div class="carousel-inner">
 			{% for package in featured %}
-				{% set cover_image = package.cover_image.url or package.getMainScreenshotURL() %}
+				{% set cover_image = package.getCoverImageURL() %}
 				{% set tags =  package.tags | sort(attribute="views", reverse=True) %}
 				<div class="carousel-item {% if loop.index == 1 %}active{% endif %}">
 					<a href="{{ package.getURL("packages.view") }}">
diff --git a/app/templates/packages/game_hub.html b/app/templates/packages/game_hub.html
index bbf0ff86..91238bdc 100644
--- a/app/templates/packages/game_hub.html
+++ b/app/templates/packages/game_hub.html
@@ -11,8 +11,8 @@
 	<meta name="og:description" content="{{ _('Mods for %(title)s', title=package.title) }}"/>
 	<meta name="description" content="{{ _('Mods for %(title)s', title=package.title) }}"/>
 	<meta name="og:url" content="{{ package.getURL('packages.game_hub', absolute=True) }}"/>
-	{% if package.getMainScreenshotURL() %}
-		<meta name="og:image" content="{{ package.getMainScreenshotURL(absolute=True) }}"/>
+	{% if package.getThumbnailURL(3, True) %}
+		<meta name="og:image" content="{{ package.getThumbnailURL(3, True) }}"/>
 	{% endif %}
 {% endblock %}
 
diff --git a/app/templates/packages/view.html b/app/templates/packages/view.html
index 1219d5dc..1148ce2f 100644
--- a/app/templates/packages/view.html
+++ b/app/templates/packages/view.html
@@ -12,8 +12,8 @@
 	<meta name="og:description" content="{{ package.short_desc }}"/>
 	<meta name="description" content="{{ package.short_desc }}"/>
 	<meta name="og:url" content="{{ package.getURL("packages.view", absolute=True) }}"/>
-	{% if package.getMainScreenshotURL() %}
-	<meta name="og:image" content="{{ package.getMainScreenshotURL(absolute=True) }}"/>
+	{% if package.getThumbnailURL(3, True) %}
+	<meta name="og:image" content="{{ package.getThumbnailURL(3, True) }}"/>
 	{% endif %}
 {% endblock %}
 
@@ -84,7 +84,7 @@
 		{% set package_warning=_("Non-free media") %}
 	{% endif %}
 <main>
-	{% set cover_image = package.cover_image.url or package.getMainScreenshotURL() %}
+	{% set cover_image = package.getCoverImageURL() %}
 	<header class="jumbotron pb-3"
 			style="background: linear-gradient(rgba(0, 0, 0, 0.4), rgba(0, 0, 0, 0.7)), url('{{ cover_image }}');
 				background-size: cover;