Triplehx3/contentdb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix failing CI

Browse Source
This commit is contained in:
rubenwardy
2025-08-25 13:53:31 +01:00
parent e03c8f04e1
commit 1c2a56e784
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/logic/package_approval.py
View File

@@ -46,6 +46,9 @@ class PackageValidationNote:
self.buttons.append((url, label)) self.buttons.append((url, label))
return self return self
def __repr__(self):
return str(self.message)
def is_package_name_taken(normalised_name: str) -> bool: def is_package_name_taken(normalised_name: str) -> bool:
return Package.query.filter( return Package.query.filter(

1
app/tests/unit/logic/test_approval_stats.py
View File

@@ -35,6 +35,7 @@ class MockEntry:
self.causer = causer self.causer = causer
self.created_at = datetime.datetime.strptime(date, "%Y-%m-%dT%H:%M:%S%z") self.created_at = datetime.datetime.strptime(date, "%Y-%m-%dT%H:%M:%S%z")
self.title = title self.title = title
self.description = None
self.package = MockPackage(package_id) self.package = MockPackage(package_id)

8
app/tests/unit/logic/test_package_approval.py
View File

@@ -84,6 +84,7 @@ def test_missing_hard_deps(get_forum_topic):
mock_package = MockPackageHelper(PackageType.MOD) mock_package = MockPackageHelper(PackageType.MOD)
mock_package.add_release() mock_package.add_release()
mock_package.add_missing_hard_deps() mock_package.add_missing_hard_deps()
mock_package.add_screenshot()
topic = MagicMock() topic = MagicMock()
topic.author = mock_package.package.author topic.author = mock_package.package.author
@@ -103,6 +104,7 @@ def test_requires_multiple_issues():
mock_package.add_release() mock_package.add_release()
mock_package.set_license("Other", "Other") mock_package.set_license("Other", "Other")
mock_package.set_no_game_support() mock_package.set_no_game_support()
mock_package.add_screenshot()
notes = package_approval.validate_package_for_approval(mock_package.package) notes = package_approval.validate_package_for_approval(mock_package.package)
assert len(notes) == 5 assert len(notes) == 5
@@ -120,6 +122,7 @@ def test_requires_multiple_issues():
def test_forum_topic_author_mismatch(get_forum_topic): def test_forum_topic_author_mismatch(get_forum_topic):
mock_package = MockPackageHelper() mock_package = MockPackageHelper()
mock_package.add_release() mock_package.add_release()
mock_package.add_screenshot()
topic = MagicMock() topic = MagicMock()
get_forum_topic.return_value = topic get_forum_topic.return_value = topic
@@ -136,6 +139,7 @@ def test_forum_topic_author_mismatch(get_forum_topic):
def test_passes(get_forum_topic): def test_passes(get_forum_topic):
mock_package = MockPackageHelper() mock_package = MockPackageHelper()
mock_package.add_release() mock_package.add_release()
mock_package.add_screenshot()
topic = MagicMock() topic = MagicMock()
topic.author = mock_package.package.author topic.author = mock_package.package.author
@@ -168,8 +172,8 @@ def test_games_txp_must_have_unique_name(get_forum_topic):
@patch("app.logic.package_approval.get_conflicting_mod_names", MagicMock(return_value=set())) @patch("app.logic.package_approval.get_conflicting_mod_names", MagicMock(return_value=set()))
@patch("app.logic.package_approval.count_packages_with_forum_topic", MagicMock(return_value=1)) @patch("app.logic.package_approval.count_packages_with_forum_topic", MagicMock(return_value=1))
@patch("app.logic.package_approval.get_forum_topic") @patch("app.logic.package_approval.get_forum_topic")
def test_games_txp_require_screenshots(get_forum_topic): def test_require_screenshots(get_forum_topic):
mock_package = MockPackageHelper(PackageType.GAME) mock_package = MockPackageHelper(PackageType.MOD)
mock_package.add_release() mock_package.add_release()
topic = MagicMock() topic = MagicMock()