Added architecture parsing and displaying, save chosen channel per-session

This commit is contained in:
Latif Khalifa
2013-11-15 00:13:41 +01:00
parent 7ac4f291bf
commit cf487bb719
6 changed files with 20 additions and 4 deletions

View File

@@ -155,7 +155,7 @@ if ($signature_id):
<tr class="rowhighlight" data-signature-id="<?php echo $reports[$i]->signature_id ?>" data-id="<?php echo $reports[$i]->id ?>">
<td><?php lk($reports[$i]->id, $reports[$i]->id) ?></td>
<td><?php lk($reports[$i]->id, $reports[$i]->client_channel . " " . $reports[$i]->client_version) ?></td>
<td><?php lk($reports[$i]->id, $reports[$i]->os) ?></td>
<td><?php lk($reports[$i]->id, $reports[$i]->os . ($reports[$i]->client_arch ? " (" . $reports[$i]->client_arch . ")" : ""))?></td>
<td><?php lk($reports[$i]->id, $reports[$i]->gpu) ?></td>
<td><?php lk($reports[$i]->id, $reports[$i]->grid . " (" . $reports[$i]->region . ")") ?></td>
<td><a href="<?php echo URL_ROOT . "/crashes.php?signature_id=" . $reports[$i]->signature_id ?>"><?php echo $reports[$i]->signature_id ?> </a></td>

View File

@@ -6,6 +6,7 @@ class CrashReport
public $reported;
public $client_version;
public $client_channel;
public $client_arch;
public $os;
public $os_type;
public $os_version;
@@ -83,7 +84,7 @@ class CrashReport
}
}
function getReports($filter, $fields = "id, reported, client_version, client_channel, os, gpu, grid, region, signature_id")
function getReports($filter, $fields = "id, reported, client_version, client_channel, client_arch, os, gpu, grid, region, signature_id")
{
$ret = array();
$q = "select $fields from reports " . $filter->getWhere() . kl_str_sql(" order by id desc limit !i offset !i", $filter->limit, $filter->offset);
@@ -150,6 +151,7 @@ class CrashReport
client_version,
client_version_s,
client_channel,
client_arch,
os,
os_type,
os_version,
@@ -163,12 +165,13 @@ class CrashReport
crash_address,
crash_thread,
raw_stacktrace
) values (!i, !t, !s, !s, !s, !s, !s, !s, !s, !s, !s, !i, !s, !s, !s, !s, !i, !s)",
) values (!i, !t, !s, !s, !s, !s, !s,!s, !s, !s, !s, !s, !i, !s, !s, !s, !s, !i, !s)",
$this->id,
$this->reported,
$this->client_version,
self::sortableVersion($this->client_version),
$this->client_channel,
$this->client_arch,
$this->os,
$this->os_type,
$this->os_version,
@@ -383,6 +386,7 @@ class CrashReport
$this->reported = $data["reported"];
$this->client_version = $data["clientVersion"];
$this->client_channel = $data["clientChannel"];
$this->client_arch = $data["clientArch"];
$this->os = $data["DebugLog"]["OSInfo"];
$this->gpu = $data["DebugLog"]["GraphicsCard"];
$this->cpu = $data["DebugLog"]["CPUInfo"]["CPUString"];

View File

@@ -53,6 +53,7 @@ class ReportParser
//var_dump($client);
$data->report["clientVersion"] = $client["MajorVersion"] . "." . $client["MinorVersion"] . "." . $client["PatchVersion"] . "." .$client["BuildVersion"];
$data->report["clientChannel"] = str_replace(" ", "", $client["Name"]);
$data->report["clientArch"] = $client["Architecture"];
}
// $data->report["raw"] = $row;

View File

@@ -25,6 +25,8 @@ class SearchFilter
function __construct()
{
global $S;
foreach($this->fields as $field)
{
if (strlen($_GET[$field]))
@@ -32,6 +34,15 @@ class SearchFilter
$this->$field = trim($_GET[$field]);
}
}
if (!isset($_REQUEST["chan"]))
{
$this->chan = $S->persist->chan;
}
else
{
$S->persist->chan = $_REQUEST["chan"];
}
if (in_array($_GET["sort_by"], self::$sort_keys))
{

View File

@@ -186,7 +186,6 @@ class Session
$this->user = $user;
$this->user_id = $user->user_id;
$this->authenticated = true;
$this->persist->active_order = null;
$this->update();
return true;
}

View File

@@ -40,6 +40,7 @@ create table reports(
client_version varchar(32),
client_version_s varchar(32),
client_channel varchar(32),
client_arch varchar(16),
os varchar(128),
os_type varchar(32),
os_version varchar(128),