From fae8f7803ef0fba03f61b98dab9203412ca96ab2 Mon Sep 17 00:00:00 2001 From: Aleric Inglewood Date: Sat, 25 Jun 2011 13:45:04 +0200 Subject: [PATCH] Fix for Communicate flyout button. Remove erroneously linked control variable. The 'value' of a LLFlyoutButton is the (last) selected value: a string. Linking it to some random boolean control variable causes this value to be (re)assigned to the flyout button list through LLControlVariable::setValue (whenever said boolean changes, in this case when the floater is made to appear) which calls getComparableValue with the string value (ie "mute list") and tries to convert that to a boolean. Obviously That fails and the value is set to "", effectively having nothing selected anymore. This fixes http://code.google.com/p/singularity-viewer/issues/detail?id=21 --- indra/newview/lltoolbar.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/indra/newview/lltoolbar.cpp b/indra/newview/lltoolbar.cpp index 593a382cd..44fc368f3 100644 --- a/indra/newview/lltoolbar.cpp +++ b/indra/newview/lltoolbar.cpp @@ -126,7 +126,6 @@ LLToolBar::LLToolBar() BOOL LLToolBar::postBuild() { childSetCommitCallback("communicate_btn", onClickCommunicate, this); - childSetControlName("communicate_btn", "ShowCommunicate"); childSetAction("chat_btn", onClickChat, this); childSetControlName("chat_btn", "ChatVisible");