From d15ed9ed3471c8027fc7d23f5b01f86e46445e7f Mon Sep 17 00:00:00 2001 From: Shyotl Date: Tue, 31 Jan 2012 02:54:42 -0600 Subject: [PATCH] I borked up the sUseStreamDraw logic earlier. When its a stream type, and sUseStreamDraw is false, don't use a vbo at all (I mistakenly had it use a dynamic vbo instead). Also, removed an unused (due to being renamed) setting from settings.xml --- indra/llrender/llvertexbuffer.cpp | 9 ++++----- indra/newview/app_settings/settings.xml | 11 ----------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/indra/llrender/llvertexbuffer.cpp b/indra/llrender/llvertexbuffer.cpp index 99fcebc4a..6a9ee5997 100644 --- a/indra/llrender/llvertexbuffer.cpp +++ b/indra/llrender/llvertexbuffer.cpp @@ -753,16 +753,15 @@ S32 LLVertexBuffer::determineUsage(S32 usage) if (LLRender::sGLCoreProfile) { //MUST use VBOs for all rendering if(!usage) - usage = GL_STREAM_DRAW_ARB; + return GL_STREAM_DRAW_ARB; } - else if (!sEnableVBOs || !usage) + else if (!sEnableVBOs || !usage || (!sUseStreamDraw && usage == GL_STREAM_DRAW_ARB)) { return 0; } - //Only stream_draw and dynamic_draw are supported when using VBOs, dynamic draw is the default. - //Always use stream_draw VBO if mapping is disabled, or stream is enabled and preferred/expected - if( sDisableVBOMapping || (sUseStreamDraw && (sPreferStreamDraw || usage == GL_STREAM_DRAW_ARB))) + //Always use stream_draw VBO if mapping is disabled, or stream is preferred or expected + if( sDisableVBOMapping || sPreferStreamDraw || (usage == GL_STREAM_DRAW_ARB)) { return GL_STREAM_DRAW_ARB; } diff --git a/indra/newview/app_settings/settings.xml b/indra/newview/app_settings/settings.xml index 1cdd74902..55f6a70f0 100644 --- a/indra/newview/app_settings/settings.xml +++ b/indra/newview/app_settings/settings.xml @@ -11379,17 +11379,6 @@ Boolean Value 1 - - RenderUseStreamVBO - - Comment - Use VBO's for stream buffers - Persist - 1 - Type - Boolean - Value - 1 RenderPreferStreamDraw