Singularity-Viewer/SingularityViewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pass filename by reference when possible.

Browse Source
This commit is contained in:
Aleric Inglewood
2012-09-18 05:01:34 +02:00
parent b5b6d3f85c
commit c67f010302
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
indra/newview/lllogchat.cpp
View File

@@ -99,7 +99,7 @@ std::string LLLogChat::timestamp(bool withdate)
//static //static
void LLLogChat::saveHistory(std::string filename, std::string line) void LLLogChat::saveHistory(std::string const& filename, std::string line)
{ {
if(!filename.size()) if(!filename.size())
{ {
@@ -120,7 +120,7 @@ void LLLogChat::saveHistory(std::string filename, std::string line)
} }
} }
void LLLogChat::loadHistory(std::string filename , void (*callback)(ELogLineType,std::string,void*), void* userdata) void LLLogChat::loadHistory(std::string const& filename , void (*callback)(ELogLineType,std::string,void*), void* userdata)
{ {
if(!filename.size()) if(!filename.size())
{ {

8
indra/newview/lllogchat.h
View File

@@ -34,6 +34,8 @@
#ifndef LL_LLLOGCHAT_H #ifndef LL_LLLOGCHAT_H
#define LL_LLLOGCHAT_H #define LL_LLLOGCHAT_H
#include <string>
class LLLogChat class LLLogChat
{ {
public: public:
@@ -44,9 +46,9 @@ public:
LOG_END LOG_END
}; };
static std::string timestamp(bool withdate = false); static std::string timestamp(bool withdate = false);
static std::string makeLogFileName(std::string(filename)); static std::string makeLogFileName(std::string filename);
static void saveHistory(std::string filename, std::string line); static void saveHistory(std::string const& filename, std::string line);
static void loadHistory(std::string filename, static void loadHistory(std::string const& filename,
void (*callback)(ELogLineType,std::string,void*), void (*callback)(ELogLineType,std::string,void*),
void* userdata); void* userdata);
private: private: