diff --git a/indra/newview/llfloaterpostcard.cpp b/indra/newview/llfloaterpostcard.cpp index 816eb3614..045acd953 100644 --- a/indra/newview/llfloaterpostcard.cpp +++ b/indra/newview/llfloaterpostcard.cpp @@ -103,11 +103,7 @@ void LLFloaterPostcard::init() if(!gAgent.getID().isNull()) { // we're logged in, so we can get this info. - gMessageSystem->newMessageFast(_PREHASH_UserInfoRequest); - gMessageSystem->nextBlockFast(_PREHASH_AgentData); - gMessageSystem->addUUIDFast(_PREHASH_AgentID, gAgent.getID()); - gMessageSystem->addUUIDFast(_PREHASH_SessionID, gAgent.getSessionID()); - gAgent.sendReliableMessage(); + gAgent.sendAgentUserInfoRequest(); } sInstances.insert(this); @@ -233,7 +229,7 @@ void LLFloaterPostcard::onClose(bool app_quitting) destroy(); } -class LLSendPostcardResponder : public LLAssetUploadResponder +class LLSendPostcardResponder final : public LLAssetUploadResponder { private: int mSnapshotIndex; @@ -248,22 +244,22 @@ public: { } // *TODO define custom uploadFailed here so it's not such a generic message - /*virtual*/ void uploadComplete(const LLSD& content) + void uploadComplete(const LLSD& content) override final { // we don't care about what the server returns from this post, just clean up the UI LLFloaterSnapshot::savePostcardDone(true, mSnapshotIndex); } - /*virtual*/ void uploadFailure(const LLSD& content) + void uploadFailure(const LLSD& content) override final { LLAssetUploadResponder::uploadFailure(content); LLFloaterSnapshot::savePostcardDone(false, mSnapshotIndex); } - /*virtual*/ void httpFailure(void) + void httpFailure(void) override final { LLAssetUploadResponder::httpFailure(); LLFloaterSnapshot::savePostcardDone(false, mSnapshotIndex); } - /*virtual*/ char const* getName(void) const { return "LLSendPostcardResponder"; } + char const* getName(void) const override final { return "LLSendPostcardResponder"; } }; // static @@ -273,7 +269,6 @@ void LLFloaterPostcard::onClickSend(void* data) { LLFloaterPostcard *self = (LLFloaterPostcard *)data; - std::string from(self->childGetValue("from_form").asString()); std::string to(self->childGetValue("to_form").asString()); boost::regex emailFormat("[A-Za-z0-9.%+-_]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,}(,[ \t]*[A-Za-z0-9.%+-_]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,})*"); @@ -284,12 +279,6 @@ void LLFloaterPostcard::onClickSend(void* data) return; } - if (from.empty() || !boost::regex_match(from, emailFormat)) - { - LLNotificationsUtil::add("PromptSelfEmail"); - return; - } - std::string subject(self->childGetValue("subject_form").asString()); if(subject.empty() || !self->mHasFirstMsgFocus) { @@ -349,10 +338,8 @@ void LLFloaterPostcard::uploadCallback(const LLUUID& asset_id, void *user_data, // static void LLFloaterPostcard::updateUserInfo(const std::string& email) { - for (instance_list_t::iterator iter = sInstances.begin(); - iter != sInstances.end(); ++iter) + for (auto& instance : sInstances) { - LLFloaterPostcard *instance = *iter; const std::string& text = instance->childGetValue("from_form").asString(); if (text.empty()) { @@ -416,7 +403,6 @@ void LLFloaterPostcard::sendPostcard() // the capability already encodes: agent ID, region ID body["pos-global"] = mPosTakenGlobal.getValue(); body["to"] = childGetValue("to_form").asString(); - body["from"] = childGetValue("from_form").asString(); body["name"] = childGetValue("name_form").asString(); body["subject"] = childGetValue("subject_form").asString(); body["msg"] = childGetValue("msg_form").asString(); diff --git a/indra/newview/llfloaterpostcard.h b/indra/newview/llfloaterpostcard.h index e40479c17..2ae0f2fa9 100644 --- a/indra/newview/llfloaterpostcard.h +++ b/indra/newview/llfloaterpostcard.h @@ -46,17 +46,17 @@ class LLLineEditor; class LLButton; class LLImageJPEG; -class LLFloaterPostcard +class LLFloaterPostcard final : public LLFloater { public: LLFloaterPostcard(LLImageJPEG* jpeg, LLViewerTexture *img, const LLVector2& img_scale, const LLVector3d& pos_taken_global, int index); - /*virtual*/ ~LLFloaterPostcard(); + /*virtual*/ ~LLFloaterPostcard() override; - /*virtual*/ void init(); - /*virtual*/ BOOL postBuild(); - /*virtual*/ void draw(); - /*virtual*/ void onClose(bool app_quitting); + void init(); + /*virtual*/ BOOL postBuild() override; + /*virtual*/ void draw() override; + /*virtual*/ void onClose(bool app_quitting) override; static LLFloaterPostcard* showFromSnapshot(LLImageJPEG *jpeg, LLViewerTexture *img, const LLVector2& img_scale, const LLVector3d& pos_taken_global, int index);