Singularity-Viewer/SingularityViewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rule #1: Do Not Lie!

Browse Source 
Don't lie about status codes to responders anymore
This may cause some bugs, but I highly doubt it, anyway, if it does,
that's what responders are for, to specialize handling in these situations.
This commit is contained in:
Lirusaito
2019-03-07 16:26:24 -05:00
parent c6cc69b01b
commit b005b2a53a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
indra/llmessage/aicurlthread.cpp
View File

@@ -2291,12 +2291,13 @@ size_t BufferedCurlEasyRequest::curlHeaderCallback(char* data, size_t size, size
} }
else else
{ {
reason = "Unexpected HTTP status."; //reason = "Unexpected HTTP status.";
LL_WARNS() << "Received unexpected status value from server (" << status << "): \"" << header << "\"" << LL_ENDL; LL_WARNS() << "Received unexpected status value from server (" << status << "): \"" << header << "\"" << LL_ENDL;
} }
// Singu TODO: WHAT THE HELL WAS THIS?! LYING? WHY WERE WE LYING???? Responders USE These Codes!!!!!
// Either way, this status value is not understood (or taken into account). // Either way, this status value is not understood (or taken into account).
// Set it to internal error so that the rest of code treats it as an error. // Set it to internal error so that the rest of code treats it as an error.
status = HTTP_INTERNAL_ERROR_OTHER; if (!status) status = HTTP_INTERNAL_ERROR_OTHER;
} }
self_w->received_HTTP_header(); self_w->received_HTTP_header();
self_w->setStatusAndReason(status, reason); self_w->setStatusAndReason(status, reason);