From 58ff4a00f15678d65419e675ee7552c59cbf4a67 Mon Sep 17 00:00:00 2001
From: Lirusaito <inusaito@gmail.com>
Date: Fri, 6 Jul 2012 12:14:55 -0400
Subject: [PATCH 1/2] Some very good points Voodoo had, and some things I
 noticed and had to correct.

---
 .../app_settings/settings_per_account.xml      |   8 --------
 .../installers/windows/installer_template.nsi  |   2 +-
 .../default/xui/en-us/floater_critical.xml     |   3 +--
 .../skins/default/xui/en-us/floater_tools.xml  |  17 ++++++-----------
 .../skins/silver/textures/arrow_left.tga       | Bin 0 -> 424 bytes
 .../skins/silver/textures/arrow_right.tga      | Bin 0 -> 424 bytes
 6 files changed, 8 insertions(+), 22 deletions(-)
 create mode 100644 indra/newview/skins/silver/textures/arrow_left.tga
 create mode 100644 indra/newview/skins/silver/textures/arrow_right.tga

diff --git a/indra/newview/app_settings/settings_per_account.xml b/indra/newview/app_settings/settings_per_account.xml
index 97ff2cd19..b2602e351 100644
--- a/indra/newview/app_settings/settings_per_account.xml
+++ b/indra/newview/app_settings/settings_per_account.xml
@@ -314,14 +314,6 @@
 			<key>Value</key>
 			<integer>0</integer>
 		</map>
-	
-	
-	
-	
-	
-	
-	
-	
     <key>RLVaLoginLastLocation</key>
     <map>
       <key>Comment</key>
diff --git a/indra/newview/installers/windows/installer_template.nsi b/indra/newview/installers/windows/installer_template.nsi
index a330de1ff..7a426decc 100644
--- a/indra/newview/installers/windows/installer_template.nsi
+++ b/indra/newview/installers/windows/installer_template.nsi
@@ -69,7 +69,7 @@ SubCaption 0 $(LicenseSubTitleSetup)	; override "license agreement" text
 
 BrandingText "Prepare to Implode!"						; bottom of window text
 Icon          %%SOURCE%%\installers\windows\install_icon_singularity.ico
-UninstallIcon %%SOURCE%%\installers\windows\install_icon_singularity.ico
+UninstallIcon %%SOURCE%%\installers\windows\uninstall_icon_singularity.ico
 WindowIcon off							; show our icon in left corner
 BGGradient 9090b0 000000 notext
 CRCCheck on								; make sure CRC is OK
diff --git a/indra/newview/skins/default/xui/en-us/floater_critical.xml b/indra/newview/skins/default/xui/en-us/floater_critical.xml
index 4d1d10dde..f6c8b8937 100644
--- a/indra/newview/skins/default/xui/en-us/floater_critical.xml
+++ b/indra/newview/skins/default/xui/en-us/floater_critical.xml
@@ -8,8 +8,7 @@
 	<button bottom="15" font="SansSerif" halign="center" height="20" label="Cancel"
 	     label_selected="Cancel" left="16" mouse_opaque="true" name="Cancel"
 	     width="100" />
-	<!-- No title text here because our "critical message" is usually the
-	community standards. JC -->
+	<!-- No title text here because our "critical message" is usually the community standards. JC -->
 	<text bg_visible="false" border_drop_shadow_visible="false" border_visible="false" bottom="-35" drop_shadow_visible="true" follows="left|top" font="SansSerif" h_pad="0" halign="left" height="20" left="20" mouse_opaque="true" name="tos_heading" v_pad="0" width="552">
 		Please read the following message carefully.
 	</text>
diff --git a/indra/newview/skins/default/xui/en-us/floater_tools.xml b/indra/newview/skins/default/xui/en-us/floater_tools.xml
index 2375b379f..2480a0440 100644
--- a/indra/newview/skins/default/xui/en-us/floater_tools.xml
+++ b/indra/newview/skins/default/xui/en-us/floater_tools.xml
@@ -670,8 +670,6 @@
 			<button bottom_delta="-18" follows="top|right" font="SansSerifSmall" halign="center"
 			     height="18" label="p" left_delta="0" mouse_opaque="true" name="pastesizeclip"  enabled="true"
 			     tool_tip="Paste Size from Clipboard"  width="20" />
-				 
-				 
 			<text bg_visible="false" border_drop_shadow_visible="false" border_visible="false"
 			     bottom_delta="-14" drop_shadow_visible="true" follows="left|top"
 			     font="SansSerifSmall" h_pad="0" halign="left" height="10" left="7"
@@ -699,9 +697,6 @@
 			<button bottom_delta="-18" follows="top|right" font="SansSerifSmall" halign="center"
 			     height="18" label="p" left_delta="0" mouse_opaque="true" name="pasterotclip"  enabled="true"
 			     tool_tip="Paste Rotation from Clipboard"  width="20" />
-							 
-							 
-				 
 			<text bg_visible="false" border_drop_shadow_visible="false" border_visible="false"
 			     bottom_delta="-16" drop_shadow_visible="true" follows="left|top"
 			     font="SansSerifSmall" h_pad="0" halign="left" height="10" left="10"
@@ -1129,15 +1124,15 @@
 				follows="left|top" 
 				height="16"
 				left_delta="114" 
-			     	ncrement="0.05" 
+			    increment="0.05"
 				initial_val="1" 
 				label="Ambiance" 
 				label_width="55"
-			     	max_val="1" 
-			     	min_val="0" 
-			     	mouse_opaque="true"
-			     	name="Light Ambiance" 
-			     	width="118" />
+			    max_val="1"
+			    min_val="0"
+			    mouse_opaque="true"
+			    name="Light Ambiance"
+			    width="118" />
             <text
              type="string"
              length="1"
diff --git a/indra/newview/skins/silver/textures/arrow_left.tga b/indra/newview/skins/silver/textures/arrow_left.tga
new file mode 100644
index 0000000000000000000000000000000000000000..43fbf122df43cfd8111a42e37ba1a0fbe4f65506
GIT binary patch
literal 424
zcmZQz;9`IQ0R{mE1&)3Y7fiH+Sj;WX3@Sie0mNrObTde_4Mea2xz7C|5*LrI?0NP1
z^XLB{C1B}RkTffh8{HowcJb<g)t^3nc=vzb{D$Xn6Iwt@*nr%e389h~ADrLw<Kvs>
z|4(k1`es6y)J34UIM^gG0a8{rJI&zQ``0i2ynlB4KS=4md9@(ZvcU$ym7V(a^XI>B
z-@gBcDVvpMcnzpb3so6@)3Cek;Nq4S6T@XL!QF=N<>W}Y%UFGh2&V~Ql9w>T2~P+k
Iq5;eT0K253_W%F@

literal 0
HcmV?d00001

diff --git a/indra/newview/skins/silver/textures/arrow_right.tga b/indra/newview/skins/silver/textures/arrow_right.tga
new file mode 100644
index 0000000000000000000000000000000000000000..a92ac9ca24274d956b3dd49d9687d838070dc661
GIT binary patch
literal 424
zcmZQz;9`IQ0R{mE1&)3Y7fdvRSj;WX3>83p21={6gG9knEFj^}pFjUUy0Yh0e~83I
zAm6zSF3k$kv2T9E^G_e%{l9u(^{4(2F_4nzR=5&2AXj`snAF9S8>YVb_~!Zl2j}<v
zm=G!nQkK&KQU)eK%Ch&(t9=eq^8VTF|L<SF_%l1r;2Kc84D1xRGObx@hSy-qzJ2@t
z|JTo-|A5L)p(?{~8dxpZZ4<*~E*)Il@&c>dz{)UuIXP19GSEUKU!sK5gfPiVKxw3K
L!XCniXaKVS<}RZ5

literal 0
HcmV?d00001


From 2e073f7449e7d14b2decf4bdb988d95524b29002 Mon Sep 17 00:00:00 2001
From: Shyotl <Shyotl@gmail.com>
Date: Fri, 6 Jul 2012 23:24:00 -0500
Subject: [PATCH 2/2] Fixed an annoying discard level assertion that was being
 fired.

---
 indra/llrender/llimagegl.cpp | 16 +++++++++++-----
 indra/llrender/llimagegl.h   |  1 +
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/indra/llrender/llimagegl.cpp b/indra/llrender/llimagegl.cpp
index 061fb48e7..1e698adfc 100644
--- a/indra/llrender/llimagegl.cpp
+++ b/indra/llrender/llimagegl.cpp
@@ -352,7 +352,10 @@ void LLImageGL::destroyGL(BOOL save_state)
 					glimage->mSaveData = NULL ;
 				}
 				else
+				{
+					glimage->mSaveDiscardLevel = glimage->mCurrentDiscardLevel;
 					stored_count++;
+				}
 			}
 
 			glimage->destroyGLTexture();
@@ -379,13 +382,14 @@ void LLImageGL::restoreGL()
 		}
 		if (glimage->mSaveData.notNull())
 		{
-			if (glimage->getComponents() && glimage->mSaveData->getComponents())
+			if (glimage->getComponents() && glimage->mSaveData->getComponents() && glimage->mSaveDiscardLevel >= 0)
 			{
-				glimage->createGLTexture(glimage->mCurrentDiscardLevel, glimage->mSaveData, 0, TRUE, glimage->getCategory());
+				glimage->createGLTexture(glimage->mSaveDiscardLevel, glimage->mSaveData, 0, TRUE, glimage->getCategory());
 				stop_glerror();
 				recovered_count++;
 			}
 			glimage->mSaveData = NULL; // deletes data
+			glimage->mSaveDiscardLevel = -1;
 		}
 	}
 	llinfos << "Restored " << recovered_count << " images" << llendl;
@@ -430,7 +434,7 @@ BOOL LLImageGL::create(LLPointer<LLImageGL>& dest, const LLImageRaw* imageraw, B
 //----------------------------------------------------------------------------
 
 LLImageGL::LLImageGL(BOOL usemipmaps)
-	: mSaveData(0)
+	: mSaveData(0), mSaveDiscardLevel(-1)
 {
 	init(usemipmaps);
 	setSize(0, 0, 0);
@@ -439,7 +443,7 @@ LLImageGL::LLImageGL(BOOL usemipmaps)
 }
 
 LLImageGL::LLImageGL(U32 width, U32 height, U8 components, BOOL usemipmaps)
-	: mSaveData(0)
+	: mSaveData(0), mSaveDiscardLevel(-1)
 {
 	llassert( components <= 4 );
 	init(usemipmaps);
@@ -449,7 +453,7 @@ LLImageGL::LLImageGL(U32 width, U32 height, U8 components, BOOL usemipmaps)
 }
 
 LLImageGL::LLImageGL(const LLImageRaw* imageraw, BOOL usemipmaps)
-	: mSaveData(0)
+	: mSaveData(0), mSaveDiscardLevel(-1)
 {
 	init(usemipmaps);
 	setSize(0, 0, 0);
@@ -1415,6 +1419,8 @@ BOOL LLImageGL::readBackRaw(S32 discard_level, LLImageRaw* imageraw, bool compre
 	if (discard_level < 0)
 	{
 		discard_level = mCurrentDiscardLevel;
+		if(discard_level < 0)
+			return FALSE;
 	}
 	
 	if (mTexName == 0 || discard_level < mCurrentDiscardLevel || discard_level > mMaxDiscardLevel )
diff --git a/indra/llrender/llimagegl.h b/indra/llrender/llimagegl.h
index e90b242e1..a80dd0998 100644
--- a/indra/llrender/llimagegl.h
+++ b/indra/llrender/llimagegl.h
@@ -183,6 +183,7 @@ public:
 	
 private:
 	LLPointer<LLImageRaw> mSaveData; // used for destroyGL/restoreGL
+	S32	mSaveDiscardLevel;
 	U8* mPickMask;  //downsampled bitmap approximation of alpha channel.  NULL if no alpha channel
 	U16 mPickMaskWidth;
 	U16 mPickMaskHeight;