diff --git a/indra/newview/llviewermessage.cpp b/indra/newview/llviewermessage.cpp index c02fb8683..1257df80c 100644 --- a/indra/newview/llviewermessage.cpp +++ b/indra/newview/llviewermessage.cpp @@ -3693,6 +3693,9 @@ void process_chat_from_simulator(LLMessageSystem *msg, void **user_data) chat.mText = from_name; mesg = mesg.substr(3); ircstyle = TRUE; + // This block was moved up to allow bubbles with italicized chat + // set CHAT_STYLE_IRC to avoid adding Avatar Name as author of message. See EXT-656 + chat.mChatStyle = CHAT_STYLE_IRC; } chat.mText += mesg; @@ -3720,12 +3723,23 @@ void process_chat_from_simulator(LLMessageSystem *msg, void **user_data) return; } + // We have a real utterance now, so can stop showing "..." and proceed. + if (chatter && chatter->isAvatar()) + { + LLLocalSpeakerMgr::getInstance()->setSpeakerTyping(from_id, FALSE); + static_cast(chatter)->stopTyping(); + + if (!is_muted && !is_busy) + { + static const LLCachedControl use_chat_bubbles("UseChatBubbles",false); + visible_in_chat_bubble = use_chat_bubbles; + static_cast(chatter)->addChat(chat); + } + } + // Look for IRC-style emotes if (ircstyle) { - // set CHAT_STYLE_IRC to avoid adding Avatar Name as author of message. See EXT-656 - chat.mChatStyle = CHAT_STYLE_IRC; - // Do nothing, ircstyle is fixed above for chat bubbles } else @@ -3852,20 +3866,6 @@ void process_chat_from_simulator(LLMessageSystem *msg, void **user_data) chat.mText = from_name + verb + mesg; } - // We have a real utterance now, so can stop showing "..." and proceed. - if (chatter && chatter->isAvatar()) - { - LLLocalSpeakerMgr::getInstance()->setSpeakerTyping(from_id, FALSE); - ((LLVOAvatar*)chatter)->stopTyping(); - - if (!is_muted && !is_busy) - { - static const LLCachedControl use_chat_bubbles("UseChatBubbles",false); - visible_in_chat_bubble = use_chat_bubbles; - ((LLVOAvatar*)chatter)->addChat(chat); - } - } - if (chatter) { chat.mPosAgent = chatter->getPositionAgent(); diff --git a/indra/newview/llvoavatar.cpp b/indra/newview/llvoavatar.cpp index e35c88e0b..6146f6d48 100644 --- a/indra/newview/llvoavatar.cpp +++ b/indra/newview/llvoavatar.cpp @@ -3318,6 +3318,13 @@ void LLVOAvatar::idleUpdateNameTagText(BOOL new_name) { F32 chat_fade_amt = llclamp((F32)((LLFrameTimer::getElapsedSeconds() - chat_iter->mTime) / CHAT_FADE_TIME), 0.f, 4.f); LLFontGL::StyleFlags style; + + // Singu Note: The following tweak may be a bad idea, though they've asked for actions to be italicized, the chat type for actions becomes irrelevant + // If LLFontGL::StyleFlags wasn't the parameter type, font styles could be combined and underline could be used, but that may be unnatural... + static const LLCachedControl italicize("LiruItalicizeActions"); + if (italicize && chat_iter->mChatStyle == CHAT_STYLE_IRC) + style = LLFontGL::ITALIC; + else switch(chat_iter->mChatType) { case CHAT_TYPE_WHISPER: