Singularity-Viewer/SingularityViewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid crashing at exit by joining the curl thread.

Browse Source
This commit is contained in:
Aleric Inglewood
2012-12-28 16:43:34 +01:00
parent aab764a6e5
commit 88bf01fe6f
1 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
indra/llmessage/aicurlthread.cpp
View File

@@ -838,6 +838,9 @@ class AICurlThread : public LLThread
// MAIN-THREAD // MAIN-THREAD
void stop_thread(void) { mRunning = false; wakeup_thread(); } void stop_thread(void) { mRunning = false; wakeup_thread(); }
// MAIN-THREAD
apr_status_t join_thread(void);
protected: protected:
virtual void run(void); virtual void run(void);
void wakeup(AICurlMultiHandle_wat const& multi_handle_w); void wakeup(AICurlMultiHandle_wat const& multi_handle_w);
@@ -1110,6 +1113,17 @@ void AICurlThread::wakeup_thread(void)
#endif #endif
} }
apr_status_t AICurlThread::join_thread(void)
{
apr_status_t retval = APR_SUCCESS;
if (sInstance)
{
apr_thread_join(&retval, sInstance->mAPRThreadp);
delete sInstance;
}
return retval;
}
void AICurlThread::wakeup(AICurlMultiHandle_wat const& multi_handle_w) void AICurlThread::wakeup(AICurlMultiHandle_wat const& multi_handle_w)
{ {
DoutEntering(dc::curl, "AICurlThread::wakeup"); DoutEntering(dc::curl, "AICurlThread::wakeup");
@@ -2148,12 +2162,22 @@ void stopCurlThread(void)
if (AICurlThread::sInstance) if (AICurlThread::sInstance)
{ {
AICurlThread::sInstance->stop_thread(); AICurlThread::sInstance->stop_thread();
int count = 101; int count = 401;
while(--count && !AICurlThread::sInstance->isStopped()) while(--count && !AICurlThread::sInstance->isStopped())
{ {
ms_sleep(10); ms_sleep(10);
} }
Dout(dc::curl, "Curl thread" << (curlThreadIsRunning() ? " not" : "") << " stopped after " << ((100 - count) * 10) << "ms."); if (AICurlThread::sInstance->isStopped())
{
// isStopped() returns true somewhere at the end of run(),
// but that doesn't mean the thread really stopped: it still
// needs to destroy it's static variables.
// If we don't join here, then there is a chance that the
// curl thread will crash when using globals that we (the
// main thread) will have destroyed before it REALLY finished.
AICurlThread::sInstance->join_thread(); // Wait till it is REALLY done.
}
llinfos << "Curl thread" << (curlThreadIsRunning() ? " not" : "") << " stopped after " << ((400 - count) * 10) << "ms." << llendl;
} }
} }