Singularity-Viewer/SingularityViewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use mAvatarNameCacheConnection, because it does indeed lead to partially populated namelists as predicted

Browse Source
This commit is contained in:
Lirusaito
2013-07-18 21:55:18 -04:00
parent a74b8ddc6b
commit 85e667bb35
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
indra/newview/llnamelistctrl.cpp
View File

@@ -199,11 +199,12 @@ LLScrollListItem* LLNameListCtrl::addNameItemRow(
// ...schedule a callback
// This is not correct and will likely lead to partially populated lists in cases where avatar names are not cached.
// *TODO : Change this to have 2 callbacks : one callback per list item and one for the whole list.
/* Singu Note: Indeed it does, for now let's not use it
if (mAvatarNameCacheConnection.connected())
{
mAvatarNameCacheConnection.disconnect();
}
mAvatarNameCacheConnection = LLAvatarNameCache::get(id,boost::bind(&LLNameListCtrl::onAvatarNameCache,this, _1, _2, item->getHandle()));
mAvatarNameCacheConnection =*/ LLAvatarNameCache::get(id,boost::bind(&LLNameListCtrl::onAvatarNameCache,this, _1, _2, item->getHandle()));
}
break;
}
@@ -262,7 +263,7 @@ void LLNameListCtrl::onAvatarNameCache(const LLUUID& agent_id,
const LLAvatarName& av_name,
LLHandle<LLNameListItem> item)
{
mAvatarNameCacheConnection.disconnect();
//mAvatarNameCacheConnection.disconnect();
std::string name;
if (mShortNames)