And now it actually compiles...

This commit is contained in:
Drake Arconis
2013-03-04 18:05:21 -05:00
parent c718bc4214
commit 5cf556fa09
2 changed files with 9 additions and 11 deletions

View File

@@ -105,7 +105,7 @@ public:
void handleRegionChange(LLTabContainer* container)
{
if ((LLViewerRegion* region = gAgent.getRegion()))
if (LLViewerRegion* region = gAgent.getRegion())
{
if (region->getFeaturesReceived())
{
@@ -120,7 +120,7 @@ public:
void setMarketplaceURL(LLTabContainer* container)
{
if ((LLViewerRegion* region = gAgent.getRegion()))
if (LLViewerRegion* region = gAgent.getRegion())
{
LLSD info;
region->getSimulatorFeatures(info);

View File

@@ -3044,10 +3044,12 @@ void LLRiggedVolume::update(const LLMeshSkinInfo* skin, LLVOAvatar* avatar, cons
}
//build matrix palette
LLMatrix4a mp[64];
static const size_t kMaxJoints = 64;
LLMatrix4a mp[kMaxJoints];
LLMatrix4* mat = (LLMatrix4*) mp;
U32 maxJoints = llmin(skin->mJointNames.size(), 64);
U32 maxJoints = llmin(skin->mJointNames.size(), kMaxJoints);
for (U32 j = 0; j < maxJoints; ++j)
{
LLJoint* joint = avatar->getJoint(skin->mJointNames[j]);
@@ -3107,13 +3109,9 @@ void LLRiggedVolume::update(const LLMeshSkinInfo* skin, LLVOAvatar* avatar, cons
LLMatrix4a src;
// Insure ref'd bone is in our clamped array of mats
llassert(idx[k] < 64);
// don't read garbage off the stack in release
if (idx[k] < 64)
{
src.setMul(mp[idx[k]], w);
}
llassert(idx[k] < kMaxJoints);
// clamp k to kMaxJoints to avoid reading garbage off stack in release
src.setMul(mp[idx[(k < kMaxJoints) ? k : 0]], w);
final_mat.add(src);
}