From 016532a618374d769271e71dcb252f3ff13b3061 Mon Sep 17 00:00:00 2001 From: Hazim Gazov Date: Wed, 9 Jun 2010 21:53:30 +0000 Subject: [PATCH 1/5] new missing delete in LLFloaterMessageLogItem::getString() --- indra/newview/llfloatermessagelog.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/indra/newview/llfloatermessagelog.cpp b/indra/newview/llfloatermessagelog.cpp index 098a35c43..36f2e92ce 100644 --- a/indra/newview/llfloatermessagelog.cpp +++ b/indra/newview/llfloatermessagelog.cpp @@ -334,6 +334,7 @@ std::string LLFloaterMessageLogItem::getString(LLTemplateMessageReader* readerp, if(i != (end - 1)) { // don't want null terminator hiding data unreadable = S32_MAX; + delete[] value; break; } } @@ -344,6 +345,7 @@ std::string LLFloaterMessageLogItem::getString(LLTemplateMessageReader* readerp, else { // never want any wrong characters outside of summary mode unreadable = S32_MAX; + delete[] value; break; } } @@ -369,6 +371,7 @@ std::string LLFloaterMessageLogItem::getString(LLTemplateMessageReader* readerp, if(summary_mode && (size > 8)) stream << " ... "; } + delete[] value; } break; } From 84ed21e525c58bec256efc7efec33b0e7ce19987 Mon Sep 17 00:00:00 2001 From: Hazim Gazov Date: Wed, 9 Jun 2010 22:01:25 +0000 Subject: [PATCH 2/5] took out delete[]s inside loops. this is a bad thing(tm) --- indra/newview/llfloatermessagelog.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/indra/newview/llfloatermessagelog.cpp b/indra/newview/llfloatermessagelog.cpp index 36f2e92ce..adb12b420 100644 --- a/indra/newview/llfloatermessagelog.cpp +++ b/indra/newview/llfloatermessagelog.cpp @@ -334,7 +334,6 @@ std::string LLFloaterMessageLogItem::getString(LLTemplateMessageReader* readerp, if(i != (end - 1)) { // don't want null terminator hiding data unreadable = S32_MAX; - delete[] value; break; } } @@ -345,7 +344,6 @@ std::string LLFloaterMessageLogItem::getString(LLTemplateMessageReader* readerp, else { // never want any wrong characters outside of summary mode unreadable = S32_MAX; - delete[] value; break; } } From 5b59859e486ba3c8d91b2c47a3444edc3196d43d Mon Sep 17 00:00:00 2001 From: Hazim Gazov Date: Wed, 9 Jun 2010 22:29:31 +0000 Subject: [PATCH 3/5] start to fix silver skin --- indra/newview/llfloatermessagelog.cpp | 5 +- .../skins/silver/xui/en-us/floater_tools.xml | 67 ++++++------------- 2 files changed, 23 insertions(+), 49 deletions(-) diff --git a/indra/newview/llfloatermessagelog.cpp b/indra/newview/llfloatermessagelog.cpp index adb12b420..f7849ab89 100644 --- a/indra/newview/llfloatermessagelog.cpp +++ b/indra/newview/llfloatermessagelog.cpp @@ -369,10 +369,13 @@ std::string LLFloaterMessageLogItem::getString(LLTemplateMessageReader* readerp, if(summary_mode && (size > 8)) stream << " ... "; } - delete[] value; } break; } + + if(value) + delete[] value; + return stream.str(); } LLMessageLogFilter::LLMessageLogFilter() diff --git a/indra/newview/skins/silver/xui/en-us/floater_tools.xml b/indra/newview/skins/silver/xui/en-us/floater_tools.xml index 081cfcac8..2e5e03b78 100644 --- a/indra/newview/skins/silver/xui/en-us/floater_tools.xml +++ b/indra/newview/skins/silver/xui/en-us/floater_tools.xml @@ -99,32 +99,27 @@ Reference -<<<<<<< -======= - - - - - - -