From 07bc115b1c4a989499428cc71f031dc222f2dac8 Mon Sep 17 00:00:00 2001 From: Shyotl Date: Tue, 19 Feb 2013 20:58:13 -0600 Subject: [PATCH 1/4] Stars had nonsensical and broken face winding. --- indra/newview/llvowlsky.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/indra/newview/llvowlsky.cpp b/indra/newview/llvowlsky.cpp index 757c04b7e..5509f9ad9 100644 --- a/indra/newview/llvowlsky.cpp +++ b/indra/newview/llvowlsky.cpp @@ -814,18 +814,18 @@ BOOL LLVOWLSky::updateStarGeometry(LLDrawable *drawable) up *= sc; *(verticesp++) = mStarVertices[vtx]; - *(verticesp++) = mStarVertices[vtx]+left; - *(verticesp++) = mStarVertices[vtx]+left+up; - *(verticesp++) = mStarVertices[vtx]+left; - *(verticesp++) = mStarVertices[vtx]+left+up; *(verticesp++) = mStarVertices[vtx]+up; + *(verticesp++) = mStarVertices[vtx]+left+up; + *(verticesp++) = mStarVertices[vtx]; + *(verticesp++) = mStarVertices[vtx]+left+up; + *(verticesp++) = mStarVertices[vtx]+left; - *(texcoordsp++) = LLVector2(0,0); - *(texcoordsp++) = LLVector2(0,1); - *(texcoordsp++) = LLVector2(1,1); - *(texcoordsp++) = LLVector2(0,1); - *(texcoordsp++) = LLVector2(1,1); *(texcoordsp++) = LLVector2(1,0); + *(texcoordsp++) = LLVector2(1,1); + *(texcoordsp++) = LLVector2(0,1); + *(texcoordsp++) = LLVector2(1,0); + *(texcoordsp++) = LLVector2(0,1); + *(texcoordsp++) = LLVector2(0,0); *(colorsp++) = LLColor4U(mStarColors[vtx]); *(colorsp++) = LLColor4U(mStarColors[vtx]); From 8d09539fccdb9690a5268ca35d210afe02efcaf5 Mon Sep 17 00:00:00 2001 From: Shyotl Date: Tue, 19 Feb 2013 21:52:13 -0600 Subject: [PATCH 2/4] Added a couple missing entries to settings.xml --- indra/newview/app_settings/settings.xml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/indra/newview/app_settings/settings.xml b/indra/newview/app_settings/settings.xml index 75eea9830..96b605b79 100644 --- a/indra/newview/app_settings/settings.xml +++ b/indra/newview/app_settings/settings.xml @@ -8163,6 +8163,17 @@ This should be as low as possible, but too low may break functionality Value 0.0 + InventoryDebugSimulateLateOpRate + + Comment + Rate at which we simulate late-completing copy/link requests in some operations + Persist + 1 + Type + F32 + Value + 0.0 + InventoryDisplayInbox Comment @@ -10667,6 +10678,17 @@ This should be as low as possible, but too low may break functionality Value 0 + QAModeMetrics + + Comment + "Enables QA features (logging, faster cycling) for metrics collector" + Persist + 1 + Type + Boolean + Value + 0 + QuietSnapshotsToDisk Comment From beeef8d5b98a3f007b361bd5472cf1c2bce65839 Mon Sep 17 00:00:00 2001 From: Shyotl Date: Tue, 19 Feb 2013 21:54:35 -0600 Subject: [PATCH 3/4] Fix crash if periodic av metric update happens after disconnect. --- indra/newview/llappviewer.cpp | 2 +- indra/newview/llvoavatarself.cpp | 13 +++++++++---- indra/newview/llvoavatarself.h | 2 +- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/indra/newview/llappviewer.cpp b/indra/newview/llappviewer.cpp index af9e0032a..96e2503d5 100644 --- a/indra/newview/llappviewer.cpp +++ b/indra/newview/llappviewer.cpp @@ -3158,7 +3158,7 @@ void LLAppViewer::requestQuit() // Try to send last batch of avatar rez metrics. if (!gDisconnected && isAgentAvatarValid()) { - gAgentAvatarp->updateAvatarRezMetrics(true); // force a last packet to be sent. + LLVOAvatarSelf::updateAvatarRezMetrics(true); // force a last packet to be sent. } LLHUDEffectSpiral *effectp = (LLHUDEffectSpiral*)LLHUDManager::getInstance()->createViewerEffect(LLHUDObject::LL_HUD_EFFECT_POINT, TRUE); diff --git a/indra/newview/llvoavatarself.cpp b/indra/newview/llvoavatarself.cpp index 8ab29f500..a4ab27f8a 100644 --- a/indra/newview/llvoavatarself.cpp +++ b/indra/newview/llvoavatarself.cpp @@ -228,7 +228,7 @@ void LLVOAvatarSelf::initInstance() } //doPeriodically(output_self_av_texture_diagnostics, 30.0); - doPeriodically(boost::bind(&LLVOAvatarSelf::updateAvatarRezMetrics, this, false), 5.0); + doPeriodically(boost::bind(&LLVOAvatarSelf::updateAvatarRezMetrics, false), 5.0); } // virtual @@ -2247,6 +2247,11 @@ private: bool LLVOAvatarSelf::updateAvatarRezMetrics(bool force_send) { + //Can be called via event system after agent avatar has been removed. + //Also skip if quit has been requested, because we already send out rez metrics when entering the quit state. + if(!isAgentAvatarValid() || LLAppViewer::instance()->quitRequested()) + return false; + const F32 AV_METRICS_INTERVAL_QA = 30.0; F32 send_period = 300.0; if (gSavedSettings.getBOOL("QAModeMetrics")) @@ -2254,13 +2259,13 @@ bool LLVOAvatarSelf::updateAvatarRezMetrics(bool force_send) send_period = AV_METRICS_INTERVAL_QA; } - if (force_send || mTimeSinceLastRezMessage.getElapsedTimeF32() > send_period) + if (force_send || gAgentAvatarp->mTimeSinceLastRezMessage.getElapsedTimeF32() > send_period) { - // Stats for completed phases have been getting logged as they + // Stats for completed phases have been getting l ogged as they // complete. This will give us stats for any timers that // haven't finished as of the metric's being sent. LLVOAvatar::logPendingPhasesAllAvatars(); - sendViewerAppearanceChangeMetrics(); + gAgentAvatarp->sendViewerAppearanceChangeMetrics(); } return false; diff --git a/indra/newview/llvoavatarself.h b/indra/newview/llvoavatarself.h index 3c0dba237..e7a59d1a3 100644 --- a/indra/newview/llvoavatarself.h +++ b/indra/newview/llvoavatarself.h @@ -380,7 +380,7 @@ public: }; LLTimer mTimeSinceLastRezMessage; - bool updateAvatarRezMetrics(bool force_send); + static bool updateAvatarRezMetrics(bool force_send); std::vector mPendingTimerRecords; void addMetricsTimerRecord(const LLSD& record); From 041481db8927acb61fd3567faaab7938c524e3c7 Mon Sep 17 00:00:00 2001 From: Shyotl Date: Tue, 19 Feb 2013 22:33:31 -0600 Subject: [PATCH 4/4] Snap grid was pulling colors from wrong control group. --- indra/newview/llmanip.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/indra/newview/llmanip.cpp b/indra/newview/llmanip.cpp index e7cdc51cc..44ab0f9bc 100644 --- a/indra/newview/llmanip.cpp +++ b/indra/newview/llmanip.cpp @@ -603,9 +603,9 @@ void LLManip::renderTickValue(const LLVector3& pos, F32 value, const std::string LLColor4 LLManip::setupSnapGuideRenderPass(S32 pass) { - static const LLCachedControl grid_color_fg("GridlineColor",LLColor4(1.f,1.f,1.f,.8f)); - static const LLCachedControl grid_color_bg("GridlineBGColor",LLColor4(.9f,.9f,1.f,.8f)); - static const LLCachedControl grid_color_shadow("GridlineShadowColor",LLColor4(0.f,0.f,0.f,.3f)); + static const LLCachedControl grid_color_fg(gColors,"GridlineColor",LLColor4(1.f,1.f,1.f,.8f)); + static const LLCachedControl grid_color_bg(gColors,"GridlineBGColor",LLColor4(.9f,.9f,1.f,.8f)); + static const LLCachedControl grid_color_shadow(gColors,"GridlineShadowColor",LLColor4(0.f,0.f,0.f,.3f)); LLColor4 line_color; static const LLCachedControl line_alpha("GridOpacity",1.f);