From 9be72ffb4706cc2352ecb07c539c771348b5e1a4 Mon Sep 17 00:00:00 2001 From: Damian Zhaoying Date: Thu, 24 Oct 2013 03:39:07 -0300 Subject: [PATCH 1/3] add spanish translation for prefs editor open log in windows option --- .../skins/default/xui/es/panel_preferences_ascent_chat.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/indra/newview/skins/default/xui/es/panel_preferences_ascent_chat.xml b/indra/newview/skins/default/xui/es/panel_preferences_ascent_chat.xml index f6790ada7..fc16bc69d 100644 --- a/indra/newview/skins/default/xui/es/panel_preferences_ascent_chat.xml +++ b/indra/newview/skins/default/xui/es/panel_preferences_ascent_chat.xml @@ -71,6 +71,7 @@ + From b34a8db34a9f88b27121a5e7c83583086e8edc97 Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Wed, 30 Oct 2013 08:37:20 -0400 Subject: [PATCH 2/3] Modernize constructor of LLPreviewSound and cure crash signature 314 --- indra/newview/llpreviewsound.cpp | 58 +++++++++++++++----------------- indra/newview/llpreviewsound.h | 1 + 2 files changed, 28 insertions(+), 31 deletions(-) diff --git a/indra/newview/llpreviewsound.cpp b/indra/newview/llpreviewsound.cpp index 163ba6056..7992ee558 100644 --- a/indra/newview/llpreviewsound.cpp +++ b/indra/newview/llpreviewsound.cpp @@ -60,10 +60,36 @@ const F32 SOUND_GAIN = 1.0f; LLPreviewSound::LLPreviewSound(const std::string& name, const LLRect& rect, const std::string& title, const LLUUID& item_uuid, const LLUUID& object_uuid) : LLPreview( name, rect, title, item_uuid, object_uuid) +, mIsCopyable(false) { LLUICtrlFactory::getInstance()->buildFloater(this,"floater_preview_sound.xml"); + setTitle(title); + + if (!getHost()) + { + LLRect curRect = getRect(); + translate(rect.mLeft - curRect.mLeft, rect.mTop - curRect.mTop); + } +} + +// virtual +BOOL LLPreviewSound::postBuild() +{ + const LLInventoryItem* item = getItem(); + if (item) + { + getChild("desc")->setValue(item->getDescription()); + mIsCopyable = (item->getPermissions().getCreator() == gAgentID); + if (gAudiop) + // + // that thing above doesn't actually start a sound transfer, so I will do it + if (LLAudioSource* asp = gAgentAvatarp->getAudioSource(gAgentID)) + asp->preload(item->getAssetUUID()); // preload the sound + // + } + childSetAction("Sound play btn",&LLPreviewSound::playSound,this); childSetAction("Sound audition btn",&LLPreviewSound::auditionSound,this); // @@ -77,40 +103,10 @@ LLPreviewSound::LLPreviewSound(const std::string& name, const LLRect& rect, cons button = getChild("Sound audition btn"); button->setSoundFlags(LLView::SILENT); - const LLInventoryItem* item = getItem(); - - mIsCopyable = false; - if(item) - { - const LLPermissions& perm = item->getPermissions(); - mIsCopyable = (perm.getCreator() == gAgent.getID()); - } - childSetCommitCallback("desc", LLPreview::onText, this); - childSetText("desc", item->getDescription()); getChild("desc")->setPrevalidate(&LLLineEditor::prevalidatePrintableNotPipe); - - // preload the sound - if(item && gAudiop) - { - // - // that thing above doesn't actually start a sound transfer, so I will do it - LLAudioSource *asp = gAgentAvatarp->getAudioSource(gAgent.getID()); - if(asp) - { - asp->preload(item->getAssetUUID()); - } - // - } - - setTitle(title); - - if (!getHost()) - { - LLRect curRect = getRect(); - translate(rect.mLeft - curRect.mLeft, rect.mTop - curRect.mTop); - } + return LLPreview::postBuild(); } // static diff --git a/indra/newview/llpreviewsound.h b/indra/newview/llpreviewsound.h index 6d8928c97..51a89d9df 100644 --- a/indra/newview/llpreviewsound.h +++ b/indra/newview/llpreviewsound.h @@ -65,6 +65,7 @@ public: // protected: + /*virtual*/ BOOL postBuild(); virtual const char *getTitleName() const { return "Sound"; } // virtual BOOL canSaveAs() const; From 73cb43e71f40ed69e73946f291b324d4f826e91b Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Wed, 30 Oct 2013 08:40:47 -0400 Subject: [PATCH 3/3] [Warnings] Fix ..\..\libhacd\hacdRaycastMesh.cpp(109): warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) All the other involved types are of size_t, so static_cast 1 should work here. --- indra/libhacd/hacdRaycastMesh.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/libhacd/hacdRaycastMesh.cpp b/indra/libhacd/hacdRaycastMesh.cpp index 5edd9adc3..2f84bbc11 100644 --- a/indra/libhacd/hacdRaycastMesh.cpp +++ b/indra/libhacd/hacdRaycastMesh.cpp @@ -106,7 +106,7 @@ namespace HACD m_nMaxNodes = 0; for(size_t k = 0; k < maxDepth; k++) { - m_nMaxNodes += (1 << maxDepth); + m_nMaxNodes += (static_cast(1) << maxDepth); } m_nodes = new RMNode[m_nMaxNodes]; RMNode & root = m_nodes[AddNode()];