From 214ed0403db836be936a72d49ed05a3f3f25a05e Mon Sep 17 00:00:00 2001 From: Salvatore La Bua Date: Tue, 1 Oct 2013 02:08:59 +0200 Subject: [PATCH 01/32] Add toggle for RenderAnimateTrees in Advanced > Rendering --- indra/newview/llviewermenu.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/indra/newview/llviewermenu.cpp b/indra/newview/llviewermenu.cpp index ae8f23910..673b0df79 100644 --- a/indra/newview/llviewermenu.cpp +++ b/indra/newview/llviewermenu.cpp @@ -1476,6 +1476,9 @@ void init_debug_rendering_menu(LLMenuGL* menu) menu->addChild(new LLMenuItemCallGL("Rebuild Vertex Buffers", reset_vertex_buffers, NULL, NULL, 'V', MASK_CONTROL | MASK_SHIFT)); + item = new LLMenuItemCheckGL("Animate Trees", menu_toggle_control, NULL, menu_check_control, (void*)"RenderAnimateTrees"); + menu->addChild(item); + item = new LLMenuItemCheckGL("Animate Textures", menu_toggle_control, NULL, menu_check_control, (void*)"AnimateTextures"); menu->addChild(item); From aa54d82c5a4b47309cd26452f34b210bcd9ddbc1 Mon Sep 17 00:00:00 2001 From: Salvatore La Bua Date: Tue, 1 Oct 2013 03:33:49 +0200 Subject: [PATCH 02/32] Fix a render issue with Hightlight Transparent The smoke texture is currently not applied to transparent objects. This commit tweaks the red alpha overlay as a workaround for that. --- indra/newview/lldrawpoolalpha.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/newview/lldrawpoolalpha.cpp b/indra/newview/lldrawpoolalpha.cpp index 7d65bd359..5fdedc68e 100644 --- a/indra/newview/lldrawpoolalpha.cpp +++ b/indra/newview/lldrawpoolalpha.cpp @@ -335,7 +335,7 @@ void LLDrawPoolAlpha::render(S32 pass) gPipeline.enableLightsFullbright(LLColor4(1,1,1,1)); } - gGL.diffuseColor4f(1,0,0,1); + gGL.diffuseColor4f(0.9,0,0,0.4); LLViewerFetchedTexture::sSmokeImagep->addTextureStats(1024.f*1024.f); gGL.getTexUnit(0)->bind(LLViewerFetchedTexture::sSmokeImagep, TRUE) ; From 1c96fa09fda74eb643a10a0b3b44cbe88fb4aafa Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Thu, 3 Oct 2013 12:41:10 -0400 Subject: [PATCH 03/32] Fix a few signed unsigned mismatches --- indra/newview/aihttpview.cpp | 2 +- indra/newview/aihttpview.h | 2 +- indra/newview/lllogchat.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/indra/newview/aihttpview.cpp b/indra/newview/aihttpview.cpp index b5c5c4538..11e5af66b 100644 --- a/indra/newview/aihttpview.cpp +++ b/indra/newview/aihttpview.cpp @@ -291,7 +291,7 @@ AIHTTPView::~AIHTTPView() mGLHTTPHeaderBar = NULL; } -U32 AIHTTPView::updateColumn(int col, U32 start) +U32 AIHTTPView::updateColumn(U32 col, U32 start) { if (col > mStartColumn.size()) { diff --git a/indra/newview/aihttpview.h b/indra/newview/aihttpview.h index 767d37e54..3fb80ea03 100644 --- a/indra/newview/aihttpview.h +++ b/indra/newview/aihttpview.h @@ -52,7 +52,7 @@ class AIHTTPView : public LLContainerView /*virtual*/ BOOL handleMouseUp(S32 x, S32 y, MASK mask); /*virtual*/ BOOL handleKey(KEY key, MASK mask, BOOL called_from_parent); - U32 updateColumn(int col, U32 start); + U32 updateColumn(U32 col, U32 start); void setWidth(S32 width) { mWidth = width; } private: diff --git a/indra/newview/lllogchat.cpp b/indra/newview/lllogchat.cpp index 4a67d41ff..d58e1e556 100644 --- a/indra/newview/lllogchat.cpp +++ b/indra/newview/lllogchat.cpp @@ -153,7 +153,7 @@ void LLLogChat::loadHistory(std::string const& filename , void (*callback)(ELogL char buffer[LOG_RECALL_BUFSIZ]; bool error = false; - int nlines = 0; + U32 nlines = 0; while (pos > 0 && nlines < lines) { // Read the LOG_RECALL_BUFSIZ characters before pos. From 2b61394234b08ace6baa5d3ca70430d665450dfc Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Thu, 3 Oct 2013 13:20:47 -0400 Subject: [PATCH 04/32] Fix /singularity/singularity-master/indra/plugins/filepicker/llfilepicker.cpp:762:61: warning: multi-character character constant OSTypes are four byte sequences, therefore we should use 'JP2 ' instead of 'JP2' --- indra/plugins/filepicker/llfilepicker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/plugins/filepicker/llfilepicker.cpp b/indra/plugins/filepicker/llfilepicker.cpp index 7f634edef..3d6803a9c 100644 --- a/indra/plugins/filepicker/llfilepicker.cpp +++ b/indra/plugins/filepicker/llfilepicker.cpp @@ -759,7 +759,7 @@ Boolean LLFilePickerBase::navOpenFilterProc(AEDesc *theItem, void *info, void *c if (fileInfo.filetype != 'JPEG' && fileInfo.filetype != 'JPG ' && fileInfo.filetype != 'BMP ' && fileInfo.filetype != 'TGA ' && fileInfo.filetype != 'BMPf' && fileInfo.filetype != 'TPIC' && - fileInfo.filetype != 'PNG ' && fileInfo.filetype != 'JP2' && + fileInfo.filetype != 'PNG ' && fileInfo.filetype != 'JP2 ' && (fileInfo.extension && (CFStringCompare(fileInfo.extension, CFSTR("jpeg"), kCFCompareCaseInsensitive) != kCFCompareEqualTo && CFStringCompare(fileInfo.extension, CFSTR("jpg"), kCFCompareCaseInsensitive) != kCFCompareEqualTo && CFStringCompare(fileInfo.extension, CFSTR("bmp"), kCFCompareCaseInsensitive) != kCFCompareEqualTo && From cfeb50ae4dfda50dbc4ce8c8b63fe1aab7725d9b Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Thu, 3 Oct 2013 13:46:16 -0400 Subject: [PATCH 05/32] Breaking pad: warning: 'OSStatus CarbonEventHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, void*)' defined but not used --- indra/newview/llappviewermacosx.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/indra/newview/llappviewermacosx.cpp b/indra/newview/llappviewermacosx.cpp index 084423880..1c74ffbe1 100644 --- a/indra/newview/llappviewermacosx.cpp +++ b/indra/newview/llappviewermacosx.cpp @@ -262,6 +262,7 @@ bool LLAppViewerMacOSX::restoreErrorTrap() return reset_count == 0; } +#if 0 // Singu Note: Defined but not used static OSStatus CarbonEventHandler(EventHandlerCallRef inHandlerCallRef, EventRef inEvent, void* inUserData) @@ -288,6 +289,7 @@ static OSStatus CarbonEventHandler(EventHandlerCallRef inHandlerCallRef, } return noErr; } +#endif void LLAppViewerMacOSX::initCrashReporting(bool reportFreeze) { From 36d658c4c4a6a95f4eb8cbd84ff5c1aef8ec5bbb Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Thu, 3 Oct 2013 19:59:11 -0400 Subject: [PATCH 06/32] Feature Request: Make Log viewing cross platform by opening in a browser window INB4 Windows users express discomfort. --- indra/newview/llfloaterchat.cpp | 7 +++---- indra/newview/llimpanel.cpp | 18 +++++++++++++----- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/indra/newview/llfloaterchat.cpp b/indra/newview/llfloaterchat.cpp index a8d430ca5..5dc3e4324 100644 --- a/indra/newview/llfloaterchat.cpp +++ b/indra/newview/llfloaterchat.cpp @@ -650,13 +650,12 @@ void LLFloaterChat::onClickToggleActiveSpeakers(void* userdata) //self->childSetVisible("active_speakers_panel", !self->childIsVisible("active_speakers_panel")); } +void show_log_browser(const std::string& name = "chat", const std::string& id = "chat"); + // static void LLFloaterChat::onClickChatHistoryOpen(void* userdata) { - std::string command("\"" + LLLogChat::makeLogFileName("chat") + "\""); - gViewerWindow->getWindow()->ShellEx(command); - - llinfos << command << llendl; + show_log_browser(); } //static diff --git a/indra/newview/llimpanel.cpp b/indra/newview/llimpanel.cpp index 9925dabc6..a394f8fd7 100644 --- a/indra/newview/llimpanel.cpp +++ b/indra/newview/llimpanel.cpp @@ -41,6 +41,7 @@ #include "llcombobox.h" #include "llfloaterchat.h" #include "llfloaterinventory.h" +#include "llfloaterwebcontent.h" // For web browser display of logs #include "llgroupactions.h" #include "llhttpclient.h" #include "llimview.h" @@ -1086,17 +1087,24 @@ void LLFloaterIMPanel::onFlyoutCommit(LLComboBox* flyout, const LLSD& value) } } +void show_log_browser(const std::string& name, const std::string& id) +{ + LLFloaterWebContent::Params p; + p.url("file:///" + LLLogChat::makeLogFileName(name)); + p.id(id); + p.show_chrome(false); + p.trusted_content(true); + LLFloaterWebContent::showInstance("log", p); // If we passed id instead of "log", there would be no control over how many log browsers opened at once. +} + void LLFloaterIMPanel::onClickHistory() { if (mOtherParticipantUUID.notNull()) { // [Ansariel: Display name support] - //std::string command("\"" + LLLogChat::makeLogFileName(getTitle()) + "\""); - std::string command("\"" + LLLogChat::makeLogFileName(mSessionLabel) + "\""); + //show_log_browser(getTitle(), mOtherParticipantUUID.asString()); + show_log_browser(mSessionLabel, mOtherParticipantUUID.asString()); // [/Ansariel: Display name support] - gViewerWindow->getWindow()->ShellEx(command); - - llinfos << command << llendl; } } From f770cb1a29b573b49bb90c5e474ed0999d2c01d1 Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Fri, 4 Oct 2013 04:43:14 -0400 Subject: [PATCH 07/32] There's no such thing as ATI Geforce... this seems to have been added because of VWR-29593, but there's no such thing... --- indra/newview/gpu_table.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/indra/newview/gpu_table.txt b/indra/newview/gpu_table.txt index ce8e013f0..7fa0e9531 100644 --- a/indra/newview/gpu_table.txt +++ b/indra/newview/gpu_table.txt @@ -76,9 +76,6 @@ ATI FirePro M5800 .*ATI.*FirePro.*M58.* 3 1 ATI FirePro M7740 .*ATI.*FirePro.*M77.* 3 1 ATI FirePro M7820 .*ATI.*FirePro.*M78.* 3 1 ATI FireMV .*ATI.*FireMV.* 0 1 -ATI Geforce 9500 GT .*ATI.*Geforce 9500 *GT.* 2 1 -ATI Geforce 9600 GT .*ATI.*Geforce 9600 *GT.* 2 1 -ATI Geforce 9800 GT .*ATI.*Geforce 9800 *GT.* 2 1 ATI Generic .*ATI.*Generic.* 0 0 ATI Hercules 9800 .*ATI.*Hercules.*9800.* 1 1 ATI IGP 340M .*ATI.*IGP.*340M.* 0 0 From d595eb331461925e96b7ac487ac9bb7dc30b70ee Mon Sep 17 00:00:00 2001 From: Latif Khalifa Date: Fri, 4 Oct 2013 23:00:48 +0200 Subject: [PATCH 08/32] Breaking pad: link SLPlugin.app with the exacption handler Fixes loading of SLPlugin on OS X --- indra/newview/viewer_manifest.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/indra/newview/viewer_manifest.py b/indra/newview/viewer_manifest.py index 2cdf9a4a5..ed54f9a39 100755 --- a/indra/newview/viewer_manifest.py +++ b/indra/newview/viewer_manifest.py @@ -552,7 +552,8 @@ class DarwinManifest(ViewerManifest): for libfile in ("libllcommon.dylib", "libapr-1.0.dylib", "libaprutil-1.0.dylib", - "libexpat.1.5.2.dylib"): + "libexpat.1.5.2.dylib", + "libexception_handler.dylib"): target_lib = os.path.join('../../..', libfile) self.run_command("ln -sf %(target)r %(link)r" % {'target': target_lib, From d7782383f1bf2655447d50d16fb4d3a511d7f408 Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Fri, 4 Oct 2013 18:29:25 -0400 Subject: [PATCH 09/32] Brokepad Mountain: Fix mac compiler warning by removing unused function and its unused static variable --- indra/newview/llappviewermacosx.cpp | 31 ----------------------------- 1 file changed, 31 deletions(-) diff --git a/indra/newview/llappviewermacosx.cpp b/indra/newview/llappviewermacosx.cpp index 1c74ffbe1..af400e766 100644 --- a/indra/newview/llappviewermacosx.cpp +++ b/indra/newview/llappviewermacosx.cpp @@ -57,8 +57,6 @@ namespace int gArgC; char** gArgV; - bool sCrashReporterIsRunning = false; - OSErr AEQuitHandler(const AppleEvent *messagein, AppleEvent *reply, long refIn) { OSErr result = noErr; @@ -262,35 +260,6 @@ bool LLAppViewerMacOSX::restoreErrorTrap() return reset_count == 0; } -#if 0 // Singu Note: Defined but not used -static OSStatus CarbonEventHandler(EventHandlerCallRef inHandlerCallRef, - EventRef inEvent, - void* inUserData) -{ - ProcessSerialNumber psn; - - GetEventParameter(inEvent, - kEventParamProcessID, - typeProcessSerialNumber, - NULL, - sizeof(psn), - NULL, - &psn); - - if( GetEventKind(inEvent) == kEventAppTerminated ) - { - Boolean matching_psn = FALSE; - OSErr os_result = SameProcess(&psn, (ProcessSerialNumber*)inUserData, &matching_psn); - if(os_result >= 0 && matching_psn) - { - sCrashReporterIsRunning = false; - QuitApplicationEventLoop(); - } - } - return noErr; -} -#endif - void LLAppViewerMacOSX::initCrashReporting(bool reportFreeze) { // Singu Note: this is where original code forks crash logger process. From 8f5337cc670b22a7ee4a93ff6806d17358596da8 Mon Sep 17 00:00:00 2001 From: Inusaito Sayori Date: Fri, 4 Oct 2013 21:01:02 -0400 Subject: [PATCH 10/32] Tooltip for grids combo box to clarify its new uses for unfamiliar users --- indra/newview/skins/default/xui/en-us/panel_login.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/newview/skins/default/xui/en-us/panel_login.xml b/indra/newview/skins/default/xui/en-us/panel_login.xml index ae63849a1..cc2257ab7 100644 --- a/indra/newview/skins/default/xui/en-us/panel_login.xml +++ b/indra/newview/skins/default/xui/en-us/panel_login.xml @@ -54,7 +54,7 @@ Grid: + left="0" mouse_opaque="true" width="120" name="grids_combo" tool_tip="Input the name/nick for a known grid or any login uri, or pick one from the list"/>